Fix illegal instruction errors on older cpus when using packaged Pony #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does Windows need a change for this @kulibali? |
Closed
SeanTAllen
added
the
triggers release
|
This should trigger another release |
|
I don't think anything is needed for Windows. |
Closed
This should be followed by modifying the makefile to allow setting -mtune to intel. This should however fix issue #1682.
SeanTAllen
force-pushed
the
baseline-prebuilt-binaries
branch
from
26e753a to
e0463c1
Compare
|
Rebased against master to get CI passing |
SeanTAllen
added
the
changelog - fixed
SeanTAllen
changed the title
ponylang-main
added a commit
that referenced
this pull request
Mar 15, 2017
This was referenced Mar 15, 2017
SeanTAllen
added a commit
that referenced
this pull request
Mar 25, 2017
In order to address problems on older CPUs with "illegal instruction" errors, we set the target CPU to x86-64 for Deb and RPM release builds. Original issue is #1682 and the PR to implement was #1686. As part of #1682, we discussed that we should also build using -mtune=intel to get better performance.
SeanTAllen
added a commit
that referenced
this pull request
Mar 25, 2017
In order to address problems on older CPUs with "illegal instruction" errors, we set the target CPU to x86-64 for Deb and RPM release builds. Original issue is #1682 and the PR to implement was #1686. As part of #1682, we discussed that we should also build using -mtune=intel to get better performance.
killerswan
pushed a commit
that referenced
this pull request
Mar 25, 2017
In order to address problems on older CPUs with "illegal instruction" errors, we set the target CPU to x86-64 for Deb and RPM release builds. Original issue is #1682 and the PR to implement was #1686. As part of #1682, we discussed that we should also build using -mtune=intel to get better performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be followed by modifying the makefile to allow
setting -mtune to intel.
This should however fix issue #1682.