Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate LLVM 3.6.2 support #1511

Merged
merged 1 commit into from
Jan 11, 2017
Merged

Deprecate LLVM 3.6.2 support #1511

merged 1 commit into from
Jan 11, 2017

Conversation

SeanTAllen
Copy link
Member

We recently deprecated OSX 3.6.x support. This commit
removes support on other platforms. Note this leaves
a note in the README about needing LLVM 3.6.2 on 32-bit
X86 FreeBSD.

We should discuss dropping support for 32-bit X86 FreeBSD
if it requires support of a LLVM version we no longer support.

@SeanTAllen SeanTAllen added changelog - changed Automatically add "Changed" CHANGELOG entry on merge needs discussion during sync do not merge This PR should not be merged at this time labels Jan 10, 2017
@SeanTAllen
Copy link
Member Author

@ponylang/committer:

Open question:

Should we drop support for 32-Bit X86 FreeBSD as it was relying on LLVM 3.6.2?

My vote is yes, especially as we have no FreeBSD CI.

@jemc
Copy link
Member

jemc commented Jan 10, 2017

The FreeBSD note was added in 72c5727 by @sylvanc, so I'd like to discuss what the specific problem was.

It's possible that the problem was resolved in 3.8.1, or in 3.9.x, so we may be able to change the note to reflect that.

@SeanTAllen
Copy link
Member Author

@jemc Feels reasonable. Not sure who, if anyone, has access to FreeBSD to test.

@sylvanc
Copy link
Contributor

sylvanc commented Jan 10, 2017

That was LLVM 3.8.0. It's quite possible that it's fixed. A vagrant 32 bit FreeBSD could give "works for me" testing, but I think the "FreeBSD on Travis" hack is needed to keep the FreeBSD port viable.

@SeanTAllen
Copy link
Member Author

We recently deprecated OSX 3.6.x support. This commit
removes support on other platforms.
@SeanTAllen SeanTAllen force-pushed the deprecate-llvm-3.6-everywhere branch from 6045cb4 to 78b806f Compare January 11, 2017 02:07
@SeanTAllen
Copy link
Member Author

I've updated this to include that LLVM 3.9.1 should be used on 32bit FreeBSD.

@SeanTAllen SeanTAllen removed do not merge This PR should not be merged at this time needs discussion during sync labels Jan 11, 2017
@jemc jemc merged commit 48feee2 into master Jan 11, 2017
ponylang-main added a commit that referenced this pull request Jan 11, 2017
@jemc jemc deleted the deprecate-llvm-3.6-everywhere branch January 11, 2017 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - changed Automatically add "Changed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants