Added String.split_by, which uses a string delimiter (issue #1399) #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to fix ponylang#1399.
|
We discussed this on the sync call. The favored course of action is to accept this PR as-is, then later refactor to use type parameter inference (#1184) and specialisation (#1410) once those two features are implemented, so that the user can pass either |
jemc
changed the title
jemc
added
the
changelog - added
jemc
changed the title
ponylang-main
added a commit
that referenced
this pull request
Nov 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature is almost the same as
String.split, we don't have any default value here. I'm not sure what'd make sense,\n,' '?There are some users of
String.splitin the stdlib and this can't be a drop-in replacement for those. If it's acceptable we can replace the current String.split uses with a Regex or move the current logic under another name (tokenize?).