This repository has been archived by the owner on Oct 14, 2023. It is now read-only.
Bugfix issue #1460 #1465
Merged
Bugfix issue #1460 #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 4, 2022 18:26
With the intention to replace it with an environment.yml file
Replacing the old configuration file 'environment.txt'
Codecov Report
@@ Coverage Diff @@
## main #1465 +/- ##
=======================================
Coverage 91.83% 91.83%
=======================================
Files 97 97
Lines 4459 4459
Branches 426 426
=======================================
Hits 4095 4095
Misses 274 274
Partials 90 90 Continue to review full report at Codecov.
|
astrojuanlu
approved these changes
Feb 4, 2022
There was a problem hiding this comment.
This looks perfect @LuisGMM ! Congratulations on your first pull request 🎉
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration file
environment.txthas been replaced by a very similar file, including all necessary dependencies,environment.yml.Note that other resolution path was intended, including another configuration file called
runtime.txtbut it did not work as expected, giving place to the issue 253 of binder's repo.The information to solve this bug has been obtained from binder's doc, and thanks to the help of @astrojuanlu.