Added gabbard.py in poliastro.plotting
#1464
Conversation
There was a problem hiding this comment.
Thanks @TheBuffer for this contribution! 🎉 I rebased your branch and everything looks good initially. I'm going to review this in depth in a few hours.
Codecov Report
@@ Coverage Diff @@
## main #1464 +/- ##
==========================================
+ Coverage 91.83% 91.91% +0.07%
==========================================
Files 97 98 +1
Lines 4459 4500 +41
Branches 426 431 +5
==========================================
+ Hits 4095 4136 +41
Misses 274 274
Partials 90 90
Continue to review full report at Codecov.
|
|
Should I try adding the Dynamic Gabbard Plots and maybe integrating something which takes in the Debris Ephemerides as an input? |
There was a problem hiding this comment.
This looks very good, thanks @TheBuffer for your contribution! I'd say let's focus on static Gabbard plots for now to make things simpler, we can expand it later.
I left some comments, but most importantly this will need some tests. You can take inspiration from the image tests we have for other plotters, that compare an expected outcome with the actual one:
https://github.com/poliastro/poliastro/tree/main/tests/tests_plotting
and added baseline image test_static_gabbard_plotting.png. Added a small Orbit List of COSMOS 1408 Debris Orbits in poliastro/examples.py to test the Gabbard Plot
|
There seem to be some subtle (unimportant) typography differences between the baseline image and the result. I downloaded
and the difference is this:
You can probably just download |
… list from examples.py to test_static_gabbard_plotting.py
|
:)) |
Tried adding a Static Gabbard Plotter as described in #1431
and tested it out with the COSMOS 1408 DEB data