Re-write encoder #34
Merged
Re-write encoder #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayrat555
force-pushed
the
ayrat555/re-write-encoder
branch
from
786d481 to
f1ce99f
Compare
This was referenced May 23, 2020
Merged
vbaranov
requested changes
May 25, 2020
There was a problem hiding this comment.
@ayrat555 I've started the review and found at least 2 wrong ABI encoded strings in the changed tests. I suppose we shouldn't change responses for existing tests because as fas as I know they are correct and checked with the stable ABI encoding JS library.
Merged
vbaranov
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version introduced a couple of bugs to the encoding/decoding of dynamic types. This PR tries to fix those bugs and also makes encoder a little bit cleaner
Fixes #22
Fixes #30
Changes: