style: use unknown in try/catch #7709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSXGitHub
reviewed
Feb 24, 2024
| } catch (err: any) { // eslint-disable-line | ||
| if (err.code === 'ENOENT') return null! | ||
| } catch (err: unknown) { | ||
| if (err instanceof Error && 'code' in err && err.code === 'ENOENT') return null! |
There was a problem hiding this comment.
So this return null! would have type never, which would mean that readCurrentLockfile has a non-null return type despite the fact that it can return null in reality?
There was a problem hiding this comment.
I don't care about it in this PR. This was like this already.
|
Looks like when code is executed by Jest, Found the solution: https://twitter.com/andhaveaniceday/status/1764442399538131039 |
zkochan
force-pushed
the
style-unknown-in-catch
branch
from
18df7eb to
702091a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.