Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: use a worker for hard linking directories #7154

Merged
merged 9 commits into from
Oct 19, 2023
Merged

perf: use a worker for hard linking directories #7154

merged 9 commits into from
Oct 19, 2023

Conversation

zkochan
Copy link
Member

@zkochan zkochan commented Oct 1, 2023

No description provided.

@zkochan zkochan marked this pull request as ready for review October 17, 2023 00:21
@zkochan zkochan merged commit 6390033 into main Oct 19, 2023
13 of 14 checks passed
@zkochan zkochan deleted the hard-link-dir-worker branch October 19, 2023 14:24
@dotnetCarpenter
Copy link

This change seems to break two tests.

fs/hard-link-dir/test/index.ts
  21:3  error  Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator  @typescript-eslint/no-floating-promises
  41:3  error  Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator  @typescript-eslint/no-floating-promises

✖ 2 problems (2 errors, 0 warnings)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zkochan @dotnetCarpenter