feat: enhance peer dependency rules #4876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 |
TravisJRyan
changed the title
zkochan
approved these changes
Jun 13, 2022
|
@zkochan Thanks for your follow-up on this - let me know if you need anything else from me to move ahead with this. |
|
Congrats on merging your first pull request! 🎉🎉🎉 |
This was referenced Jun 18, 2022
This was referenced Jul 25, 2022
This was referenced Aug 8, 2022
This was referenced Aug 16, 2022
This was referenced Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Ref #4835
Summary
This PR adds two enhancements to
peerDependencyRules:ignoreMissingsupport with pattern matchingignoreVersionfield to peer dependency rules which will allow any version of a given peer dependency (also pattern-matched) to exist. Pnpm already supports this with exhaustively listed dependencies and a "*" for allowed version, so this field adds comparable functionality to theignoreMissingabove with a pattern-matched list.Justification
This should allow pnpm greater control of peer dependency warnings without encouraging silencing warnings with something like a "silence all warnings" flag, as discussed in the issue. Users will have greater flexibility on which peer warnings (dependency missing or version-related) that they ignore and reduce noise.
Open to any feedback. Thanks for having a look.