Fix/flush pending finally everywhere #2816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/34VUXRNSQ |
See documentations for usage instructions.
dmaskasky
force-pushed
the
fix/flush-pending-finally-everywhere
branch
from
b5345b0 to
598518d
Compare
dai-shi
reviewed
Nov 14, 2024
dai-shi
reviewed
Nov 14, 2024
dai-shi
reviewed
Nov 14, 2024
dai-shi
approved these changes
Nov 14, 2024
dai-shi
added a commit
that referenced
this pull request
Nov 14, 2024
* fix: flushPending in async write * isSync in onMount to * apply the change * add test for flushPending (#2809) * Fix/flush pending finally everywhere (#2816) * call onmount flushPending in finally block * temp remove unmount test cases. to be fixed later with pending injection (#2810) * flushpending everywhere * Apply suggestions from code review --------- Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com> * fix type assertion --------- Co-authored-by: David Maskasky <dmaskasky@gmail.com>
This was referenced Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Bug Reports or Discussions
Fixes #
Summary
Check List
pnpm run prettierfor formatting code and docs