Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated features #116

Closed
wants to merge 1 commit into from

Conversation

bjornstar
Copy link
Member

@bjornstar bjornstar commented Dec 25, 2021

I noticed a bunch of comments in the code that these features were deprecated so I went ahead and removed them.

  • Remove Body.preStep
  • Remove Body.postStep
  • Remove Material.name
  • Remove World.addMaterial
  • Remove World.materials
  • Remove World.numObjects
  • Remove World.rayTest
  • Improve TupleDictionary implementation
  • [index.html] Update references to the current location of this repo
  • [Shapes] Now an abstract class

I think we should do a 1.0 release after this.

@bjornstar bjornstar force-pushed the deprecate-material-name branch 5 times, most recently from f8dc8b7 to a81a834 Compare December 26, 2021 18:35
@marcofugaro marcofugaro self-requested a review December 27, 2021 15:57
@bjornstar bjornstar force-pushed the deprecate-material-name branch from b4e24ab to cb4e833 Compare December 27, 2021 18:18
@marcofugaro
Copy link
Member

marcofugaro commented Dec 27, 2021

Hey, thanks for the effort, however this PR is too big, and it would be risky to merge it alltogether, please separate this in different PRs. 🙏

Remove Body.preStep
Remove Body.postStep

Remove Material.name

People still use the name property of the material for debug purposes, unfortunately this can't go. We can remove the @todo Deprecate this comment and just deprecate calling new CANNON.Material('test'), it can become new CANNON.Material({ name: 'test' }) instead.

Remove World.addMaterial
Remove World.materials

Remove World.numObjects

Remove World.rayTest

Need to test this more deeply, please make a PR only for this.

Improve TupleDictionary implementation

Please make a PR only for this explaining the reasoning behind this.

[index.html] Update references to the current location of this repo

[Shapes] Now an abstract class

Cool, please make a PR only for this.

I think we should do a 1.0 release after this.

Unfortunately the 1.0 goals are much broader, please look at the project objectives in the physics poimandres board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants