Reviewed 6 of 7 files at r1.
Review status: 6 of 7 files reviewed at latest revision, 1 unresolved discussion.

src/bpf_ctx.c, line 367 at r1 (raw file):

	}

	enum perf_reader_type_t perf_reader_type =

What's the problem here?

Comments from Reviewable

Reviewed 1 of 7 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

src/bpf_ctx.c, line 367 at r1 (raw file):

The type of the last argument of append_item_to_pr_arr() (below) is enum perf_reader_type_t and not enum bpf_prog_type

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

src/bpf_ctx.c, line 367 at r1 (raw file):

So, it looks like there is some problem with the design. Do we have two enums, where one is a subset of the another one?

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

src/bpf_ctx.c, line 367 at r1 (raw file):

Yes

Comments from Reviewable

Review status: 6 of 8 files reviewed at latest revision, 1 unresolved discussion.

src/bpf_ctx.c, line 367 at r1 (raw file):

Fixed

Comments from Reviewable

Review status: 6 of 8 files reviewed at latest revision, 1 unresolved discussion.

src/bpf_ctx.c, line 367 at r1 (raw file):

@krzycz I fixed it, please review the last changes

Comments from Reviewable

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

It is better to merge it before PR #26.

Reviewed 2 of 2 files at r3.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable