Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Fix #5070 - confusing argument to varargs method FP when types are unknown #5374

Merged

Conversation

oowekyala
Copy link
Member

@oowekyala oowekyala commented Nov 28, 2024

Describe the PR

Related issues

Ready?

  • needs test for when the type is (*unknown*)[]
  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@pmd-test
Copy link

pmd-test commented Nov 28, 2024

1 Message
📖 Compared to main:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Download full report as build artifact
Compared to main:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 2 errors and 7 configuration errors.
Download full report as build artifact

Generated by 🚫 Danger

@oowekyala oowekyala marked this pull request as draft November 28, 2024 11:24
wrt arrays. Make new methods that say in their
name whether they treat array as unresolved or
not. Both behaviors are desirable in different
cases.
@oowekyala oowekyala marked this pull request as ready for review November 28, 2024 15:19
@adangel adangel added this to the 7.8.0 milestone Nov 29, 2024
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adangel adangel merged commit f7920e7 into pmd:main Nov 29, 2024
3 checks passed
adangel added a commit that referenced this pull request Nov 29, 2024
adangel added a commit that referenced this pull request Nov 29, 2024
… are unknown (#5374)

Merge pull request #5374 from oowekyala:issue5070-confusingArgToVarargs-unresolved
@oowekyala oowekyala deleted the issue5070-confusingArgToVarargs-unresolved branch December 2, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[java] ConfusingArgumentToVarargsMethod FP when types are unresolved
3 participants