Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] Fix #5263 - UnnecessaryFullyQualifiedName FP with forward references #5353

Merged
merged 2 commits into from
Nov 22, 2024
Merged

[java] Fix #5263 - UnnecessaryFullyQualifiedName FP with forward references #5353

merged 2 commits into from
Nov 22, 2024

Conversation

oowekyala
Copy link
Member

@oowekyala oowekyala commented Nov 21, 2024 •
edited
Loading

Describe the PR

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@oowekyala oowekyala added the a:false-positive PMD flags a piece of code that is not problematic label Nov 21, 2024
@oowekyala oowekyala added this to the 7.8.0 milestone Nov 21, 2024
@oowekyala oowekyala changed the title [java] Fix #5263 - UnnecessaryFullyQualifiedName FP with forward refe… [java] Fix #5263 - UnnecessaryFullyQualifiedName FP with forward references Nov 21, 2024
@pmd-test
Copy link

pmd-test commented Nov 21, 2024 •
edited
Loading

1 Message
📖 Compared to main:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 7 violations, 0 errors and 0 configuration errors.
Download full report as build artifact
✅ Compared to main:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 43 violations, 0 errors and 0 configuration errors.
Download full report as build artifact

Generated by 🚫 Danger

adangel
adangel approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

...resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UnnecessaryFullyQualifiedName.xml
<expected-problems>0</expected-problems>
<code><![CDATA[

public class EnumX {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, I'll rename "EnumX" to "ClassX" to avoid further irritations... (first though, this enum won't compile because there are no constants...)

@adangel adangel merged commit 918684c into pmd:main Nov 22, 2024
3 checks passed
adangel added a commit that referenced this pull request Nov 22, 2024
@adangel
[doc] Update release notes (#5263, #5353)
9da1787
adangel added a commit that referenced this pull request Nov 22, 2024
@adangel
[java] Fix #5263 - UnnecessaryFullyQualifiedName FP with forward refe…
4f76603 
…rences (#5353)

Merge pull request #5353 from oowekyala:issue5263-ufqn-forward-ref
@oowekyala oowekyala deleted the issue5263-ufqn-forward-ref branch November 22, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adangel adangel adangel approved these changes

Assignees
No one assigned
Labels
a:false-positive PMD flags a piece of code that is not problematic
Projects
None yet
Milestone
7.8.0
Development

Successfully merging this pull request may close these issues.

[java] UnnecessaryFullyQualifiedName: false-positive in an enum that uses its own static variables
3 participants
@oowekyala @pmd-test @adangel