Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript] Add cleanup after generating ts lexer #5346

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

jsotuyod
Copy link
Member

@jsotuyod jsotuyod commented Nov 17, 2024

Describe the PR

Ensures the lexer is annotated as generated code

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@jsotuyod jsotuyod added the in:pmd-internals Affects PMD's internals label Nov 17, 2024
@jsotuyod jsotuyod added this to the 7.8.0 milestone Nov 17, 2024
@pmd-test
Copy link

1 Message
📖 No regression tested rules have been changed.

Generated by 🚫 Danger

Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adangel adangel merged commit 9f3679d into pmd:main Nov 22, 2024
3 checks passed
@jsotuyod jsotuyod deleted the fix-generated-code-typescript branch November 22, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:pmd-internals Affects PMD's internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants