Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gherkin] Remove generated gherkin code from coverage report #5336

Merged
merged 2 commits into from
Nov 17, 2024

Conversation

jsotuyod
Copy link
Member

@jsotuyod jsotuyod commented Nov 14, 2024

Describe the PR

  • Flag generated code from the grammar as such, to avoid it impacting coverage.
  • Take the chance to remove / deprecate autogenerated classes that are not needed and were not used.

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

 - Take the chance to remove / deprecate autogenerated classes that are
   not needed and were not used.
@jsotuyod jsotuyod added the in:pmd-internals Affects PMD's internals label Nov 14, 2024
@jsotuyod jsotuyod added this to the 7.8.0 milestone Nov 14, 2024
@jsotuyod jsotuyod marked this pull request as draft November 14, 2024 21:25
@pmd-test
Copy link

1 Message
📖 No regression tested rules have been changed.

Generated by 🚫 Danger

@jsotuyod jsotuyod marked this pull request as ready for review November 15, 2024 14:57
pmd-gherkin/pom.xml Show resolved Hide resolved
adangel added a commit that referenced this pull request Nov 17, 2024
adangel added a commit that referenced this pull request Nov 17, 2024
Merge pull request #5336 from Monits:fix-generated-code-gherkin
@adangel adangel merged commit 9d15c90 into pmd:main Nov 17, 2024
3 checks passed
@jsotuyod jsotuyod deleted the fix-generated-code-gherkin branch November 17, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:pmd-internals Affects PMD's internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants