Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] UseStringBufferLength - consider sb.toString().equals("") #5326

Merged
merged 3 commits into from
Nov 22, 2024
Merged

[java] UseStringBufferLength - consider sb.toString().equals("") #5326

merged 3 commits into from
Nov 22, 2024

Conversation

adangel
Copy link
Member

@adangel adangel commented Nov 14, 2024

This case is actually part of the example of the rule...

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@adangel adangel added this to the 7.8.0 milestone Nov 14, 2024
@pmd-test
Copy link

pmd-test commented Nov 14, 2024 •
edited
Loading

1 Message
📖 Compared to main:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 2 errors and 7 configuration errors.
Download full report as build artifact
✅ Compared to main:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 2 errors and 7 configuration errors.
Download full report as build artifact

Generated by 🚫 Danger

@adangel adangel requested a review from jsotuyod November 22, 2024 10:51
jsotuyod
jsotuyod approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@jsotuyod jsotuyod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jsotuyod jsotuyod merged commit d1d10c8 into pmd:main Nov 22, 2024
3 checks passed
@adangel adangel deleted the issue-5320 branch November 22, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsotuyod jsotuyod jsotuyod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.8.0
Development

Successfully merging this pull request may close these issues.

[java] UseStringBufferLength: false-negative on StringBuffer of sb.toString().equals("")
3 participants
@adangel @pmd-test @jsotuyod