Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xml] Have pmd-xml Lexer in line with other antlr grammars #5296

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

jsotuyod
Copy link
Member

Describe the PR

  • The package is no longer antlr4, but ast, as is in all other modules
  • We keep a deprecated proxy for backwards compatibility
  • We annotate the generated classes as such to ignore them from coverage reports

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

 - The package is no longer antlr4, but ast, as is in all other modules
 - We keep a deprecated proxy for backwards compatibility
 - We annotate the generated classes as such to ignore them from
   coverage reports
@jsotuyod jsotuyod added this to the 7.8.0 milestone Oct 29, 2024
@pmd-test
Copy link

1 Message
📖 No regression tested rules have been changed.

Generated by 🚫 Danger

Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

adangel added a commit that referenced this pull request Oct 31, 2024
adangel added a commit that referenced this pull request Oct 31, 2024
Merge pull request #5296 from Monits:align-xml-antlr
@adangel adangel merged commit 94095df into pmd:main Oct 31, 2024
3 checks passed
@jsotuyod jsotuyod deleted the align-xml-antlr branch October 31, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants