Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Added new error msg to ConstantsInInterface #4412

Merged
merged 2 commits into from
Mar 3, 2023

Conversation

dague1
Copy link
Contributor

@dague1 dague1 commented Mar 2, 2023

Describe the PR

Updated the error message to contain a bit more relevant information that should be useful to the programmer. Furthermore it now contains proper references to Effective Java.

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@adangel adangel added the in:documentation Affects the documentation label Mar 3, 2023
@adangel adangel added this to the 7.0.0 milestone Mar 3, 2023
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@adangel adangel changed the title [doc] Added new error msg to ConstantsInInterface and updated wiki text [doc] Added new error msg to ConstantsInInterface Mar 3, 2023
adangel added a commit that referenced this pull request Mar 3, 2023
adangel added a commit to adangel/pmd that referenced this pull request Mar 3, 2023
[doc] Added new error msg to ConstantsInInterface pmd#4412
@adangel adangel merged commit 2ed3737 into pmd:master Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:documentation Affects the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[java] Improve ConstantsInInterface message to mention alternatives
4 participants