[plsql] Fix plsql parsing error in parenthesis groups #3928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
adangel
approved these changes
Apr 21, 2022
There was a problem hiding this comment.
Thanks, looks fine!
I'll change the test to be a "BaseTreeDumpTest", so that we not only check for parse errors, but also check the parse tree. The current tests in this flavor for plsql are in https://github.com/pmd/pmd/blob/master/pmd-plsql/src/test/java/net/sourceforge/pmd/lang/plsql/ast/PlsqlTreeDumpTest.java , but I'll reuse your test class and simply convert it.
Note: You don't need to create a new PR when adding new commits, you can simply push the commits to your branch and Github will update the existing PR.
adangel
added a commit
to adangel/pmd
that referenced
this pull request
Apr 21, 2022
adangel
added a commit
to adangel/pmd
that referenced
this pull request
Apr 21, 2022
[plsql] Fix plsql parsing error in parenthesis groups pmd#3928
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
This PR fixes the plsql parser exception encountered in issue 3706. By changing the grammar in .jjt file, this parse error has been fixed and passed all added unit tests.
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)