Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] Make cli tests use dummy rules #3921

Merged
merged 7 commits into from
Apr 21, 2022
Merged

[java] Make cli tests use dummy rules #3921

merged 7 commits into from
Apr 21, 2022

Conversation

oowekyala
Copy link
Member

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@oowekyala oowekyala added this to the 6.45.0 milestone Apr 15, 2022
@pmd-test
Copy link

1 Message
📖 No regression tested rules have been changed.

Generated by 🚫 Danger

@oowekyala oowekyala added the in:testing About tests of pmd, eg the module pmd-lang-test or pmd-test label Apr 20, 2022
adangel
adangel approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

docs/pages/release_notes.md Outdated Show resolved Hide resolved
@adangel adangel merged commit 9b2a92b into pmd:master Apr 21, 2022
@oowekyala oowekyala deleted the issue3068-mock-rules-for-cli-tests branch April 21, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adangel adangel adangel approved these changes

Assignees
No one assigned
Labels
in:testing About tests of pmd, eg the module pmd-lang-test or pmd-test
Projects
None yet
Milestone
6.45.0
Development

Successfully merging this pull request may close these issues.

[java] Some tests should not depend on real rules
3 participants
@oowekyala @pmd-test @adangel