Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal handling #10

Merged
merged 3 commits into from
Jan 6, 2019
Merged

Signal handling #10

merged 3 commits into from
Jan 6, 2019

Conversation

TobiasHoll
Copy link
Member

@TobiasHoll TobiasHoll commented Dec 9, 2018

A new event type EVENT_SIGNAL is sent whenever a debugged process receives a signal (when enabled in the event mask). If a process is suspended on a signal (SUSPEND_ON_SIGNAL), issuing the cancel_signal command will stop the signal from being delivered to the process. Note that this is a destructive (but idempotent) operation; issuing the command from multiple debuggers should not result in errors.

 - Use signal_deliver instead of signal_generate tracepoint
   to avoid locking the mutex while the signal spinlock is held
 - Properly suspend on and cancel (non-fatal) signals
 - Add __get_debugger and __get_victim to allow accessing
   debugger and victim entries without automatically generating
   them (they return NULL if the entry does not exist)
@TobiasHoll TobiasHoll requested a review from klockeph December 9, 2018 20:52
Copy link
Member

@klockeph klockeph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klockeph klockeph merged commit d44b2c5 into master Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants