This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
use dash loosen-testing-reqs branch and fix linting #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcjohnson
requested review from
Marc-Andre-Rivet and
rpkyle
as code owners
alexcjohnson
commented
Dec 17, 2020
| @@ -18,6 +15,9 @@ | |||
| ) | |||
| _sys.exit(1) | |||
|
|
|||
| from ._imports_ import * # noqa: E402, F401, F403 | |||
| from ._imports_ import __all__ # noqa: E402 | |||
There was a problem hiding this comment.
The test above needs to happen before these imports or it's useless, because the components will try to use dash.development.
alexcjohnson
commented
Dec 17, 2020
.circleci/config.yml
Outdated
| @@ -32,7 +32,7 @@ jobs: | |||
| python -m venv venv || virtualenv venv | |||
| . venv/bin/activate | |||
| pip install -r dev-requirements.txt --quiet | |||
| git clone --depth 1 git@github.com:plotly/dash.git dash-main | |||
| git clone --depth 1 -b loosen-testing-reqs git@github.com:plotly/dash.git dash-main | |||
There was a problem hiding this comment.
we can revert these branches and merge this PR even before plotly/dash#1506 merges, because the changes here are fine with dash@dev
2 tasks
Marc-Andre-Rivet
approved these changes
Dec 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sanity for plotly/dash#1506