This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
fix update behaviour for multiple properties #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threaded is now True by default in flask 1.0 and `threaded=True` can’t be set if `processes>1`
chriddyp
added a commit
to plotly/dash-html-components
that referenced
this pull request
Apr 30, 2018
events have been broken since plotly/dash#232
|
Could someone from @plotly/dash please review? |
bpostlethwaite
approved these changes
Apr 30, 2018
| * update, so keep outputObservers unique. | ||
| */ | ||
| if (!contains(outputId, outputObservers)) { | ||
| outputObservers.push(outputId); |
There was a problem hiding this comment.
Perhaps in a future iteration outputObservers could become a Set or similar data structure that enforces uniqueness.
chriddyp
added a commit
to plotly/dash-html-components
that referenced
this pull request
Jun 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, if a component updates two properties in a single
setPropscall and a callback is listening to both of those properties, the callback will be called twice instead of once.this pr fixes that behaviour.
updating multiple properties at once is uncommon but was recently discovered when adding
n_clicksandn_clicks_timestampto thedash_html_componentslibrary: plotly/dash-html-components#45