This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Remove Authentication component.
#108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This looks good to me. As this neither adds a feature or fixes an issue I'm fine with not publishing this change alone. As per https://keepachangelog.com/en/1.0.0/, I think we should at least document in the changelog. Something like this:
## [Unreleased]
### Maintenance
- Remove unused Authentication component [#108](https://github.com/plotly/dash-renderer/pull/108)
T4rk1n
force-pushed
the
remove-authentication
branch
from
01e7fc8 to
2071021
Compare
|
I looked back at the Authentication component and found a @chriddyp Can you confirm that removing this api will not break anything ? |
It will not break anything |
This was referenced Dec 19, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authenticationcomponent, all it did was reading the configs.AppContainer.