Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clientside prevent update #964

Merged
merged 6 commits into from
Oct 18, 2019
Merged

Clientside prevent update #964

merged 6 commits into from
Oct 18, 2019

Conversation

jjaraalm
Copy link
Contributor

Adds dash_clientside.no_update and dash_clientside.PreventUpdate to fix #963. Integration tests added and passing.

Also changed a Popen call in _utils.py so that the path is properly searched on windows machines. Otherwise, building was failing for me. Feel free to remove if you think it's not necessary.

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • Allow clientside updates to be prevented.
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follow
    • this github #PR number updates the dash docs
    • here is the show and tell thread in plotly dash community

@alexcjohnson
Copy link
Collaborator

Thanks @jjaraalm - looks fantastic. Very nice tests, very clean implementation.

To get the linter to pass, just cd dash-renderer then npm run format. We use prettier, which is sufficiently opinionated that I don't even know how to write compliant code myself, I just have it reformat whatever I write.

@jjaraalm
Copy link
Contributor Author

Thanks! It's all good, one day I hope to make my linters happy without effort ... one day ... maybe

@alexcjohnson
Copy link
Collaborator

Alright, looks great! This definitely merits an entry in the changelog, then it'll be ready to go. We'll hold off merging for a couple of days though, as we're planning a patch release 1.4.1 and this has new features so needs to go in a minor (1.5.0)

@chriddyp
Copy link
Member

This is great 🎉
Congrats @jjaraalm on braving your way through dash-renderer/src/actions/index.js . You are one of the first community contributors to do so! 🏆 🏆 🏆

@jjaraalm
Copy link
Contributor Author

Thanks @chriddyp !

@alexcjohnson should I update the changelog or will you all do it?

@alexcjohnson
Copy link
Collaborator

@jjaraalm go for it! Just add

## Unreleased
### Added

at the top, and try to format the entry like the ones below it.

alexcjohnson
alexcjohnson reviewed Oct 18, 2019
View reviewed changes
dash/dependencies.py

if namespace in ['PreventUpdate', 'no_update']:
raise ValueError('"{}" is a forbidden namespace in'
' dash_clientside.'.format(namespace))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @rpkyle - I think this namespace exclusion is the only piece of this PR that's relevant to R

alexcjohnson
alexcjohnson approved these changes Oct 18, 2019
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Beautiful, very nicely done!

@alexcjohnson alexcjohnson merged commit e959481 into plotly:dev Oct 18, 2019
@chriddyp chriddyp mentioned this pull request Aug 26, 2020
Closed
HammadTheOne pushed a commit to HammadTheOne/dash that referenced this pull request May 28, 2021
@alexcjohnson
Merge pull request plotly#964 from plotly/dependabot/npm_and_yarn/lod…
26e6144 
…ash-4.17.21

Bump lodash from 4.17.19 to 4.17.21
HammadTheOne pushed a commit that referenced this pull request Jul 23, 2021
@alexcjohnson
Merge pull request #964 from plotly/dependabot/npm_and_yarn/lodash-4.…
f876117 
…17.21

Bump lodash from 4.17.19 to 4.17.21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

@byronz byronz Awaiting requested review from byronz

@Marc-Andre-Rivet Marc-Andre-Rivet Awaiting requested review from Marc-Andre-Rivet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clientside PreventUpdate and no_update
3 participants
@jjaraalm @alexcjohnson @chriddyp