Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove strong testing dependencies. #808

Merged
merged 3 commits into from
Jul 5, 2019
Merged

remove strong testing dependencies. #808

merged 3 commits into from
Jul 5, 2019

Conversation

byronz
Copy link
Contributor

@byronz byronz commented Jul 4, 2019

this fixes #804

the separation could be easily handled by the extra_require. and the new setup.py.

the only change might have an impact is for dash.testing users, they need to do pip install dash[testing] instead of pip install dash.

@byronz byronz requested review from chriddyp and alexcjohnson July 4, 2019 14:53
@byronz byronz requested a review from Marc-Andre-Rivet as a code owner July 4, 2019 14:53
@byronz byronz changed the title 🔧 ⬇️ remove strong testing dependencies. remove strong testing dependencies. Jul 4, 2019
percy
requests[security]
beautifulsoup4
waitress
Copy link
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet Jul 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does testing require

dash_flow_example==0.0.5
dash-dangerously-set-inner-html
virtualenv;python_version=="2.7"
mock

if not in the ci environment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they should go -ci.txt as only our integration tests need them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me double check the mock

Copy link
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@byronz byronz merged commit 373d109 into master Jul 5, 2019
@byronz byronz deleted the testing-deps branch July 5, 2019 17:03
@alexcjohnson alexcjohnson mentioned this pull request Aug 6, 2019
HammadTheOne pushed a commit to HammadTheOne/dash that referenced this pull request May 28, 2021
…down-#808

sets autoComplete to off in Dropdown plotly#808
HammadTheOne pushed a commit to HammadTheOne/dash that referenced this pull request May 28, 2021
HammadTheOne pushed a commit that referenced this pull request Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Defer pytest import?
2 participants