Flag for props check #687
Flag for props check #687
Conversation
byronz
commented
Apr 13, 2019
•
byronz
commented
- add test case once confirmed with design
|
|
||
| env_value = env.get('DASH_{}'.format(config_name.upper())) | ||
| if env_value is None: | ||
| def get_combined_config(name, val, default=None): |
There was a problem hiding this comment.
simplified the get_config by removing unnecessary parameters passing of env, and removed is_bool
| @@ -340,6 +336,7 @@ def _config(self): | |||
| 'url_base_pathname': self.url_base_pathname, | |||
| 'requests_pathname_prefix': self.config.requests_pathname_prefix, | |||
| 'dev_tools_ui': self._dev_tools.dev_tools_ui, | |||
| 'dev_tools_props_check': self._dev_tools.dev_tools_props_check, | |||
There was a problem hiding this comment.
with this, the props-check will only happen when bool(dev_tools_ui && dev_tools_props_check) == True
|
|
|
@chriddyp I saw your branch about the dev_tools_ui, adding one commit here together with props_check. note that I changed the |
| os.environ[var] = 'false' | ||
| vars = load_dash_env_vars() | ||
| self.assertEqual(vars[var], 'false') | ||
|
|
There was a problem hiding this comment.
good idea to include this run-time check 👍
…y#687) * Use start_date or min_date_allowed for initial_visible_month if initial_visible_month is undefined. * Add test for initial month. * Add datePickerRange tests. * Use max date allowed * Make function call simpler. * Run linter. * Fix typo.
* Use start_date or min_date_allowed for initial_visible_month if initial_visible_month is undefined. * Add test for initial month. * Add datePickerRange tests. * Use max date allowed * Make function call simpler. * Run linter. * Fix typo.
