Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ add dev_tools_ui in config #676

Merged
merged 5 commits into from
Apr 2, 2019
Merged

✨ add dev_tools_ui in config #676

merged 5 commits into from
Apr 2, 2019

Conversation

byronz
Copy link
Contributor

@byronz byronz commented Apr 1, 2019

this fixes #674

This PR introduces a new config dev_tools_ui to let FE know about if user has set debug=True. this implicitly enables the dev tools UI

image

@byronz byronz requested review from alexcjohnson and T4rk1n April 1, 2019 20:51
T4rk1n
T4rk1n reviewed Apr 1, 2019
View reviewed changes
dash/dash.py Outdated Show resolved Hide resolved
alexcjohnson
alexcjohnson approved these changes Apr 2, 2019
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 no need to do anything with AttributeDict in this PR, that's a totally separate issue. Unless and until we change that feel free to use dots or brackets as you please.

@nicolaskruchten
Copy link
Contributor

Does this PR enable setting debug=True and dev_tools_ui=False, which would hide the UI?

@byronz
Copy link
Contributor Author

byronz commented Apr 2, 2019

Does this PR enable setting debug=True and dev_tools_ui=False, which would hide the UI?

this PR is necessary if we wanna explicitly set the switch in the renderer

@byronz byronz merged commit 8709143 into master Apr 2, 2019
@byronz byronz deleted the add-enable-dev-tools branch April 2, 2019 15:59
@nicolaskruchten
Copy link
Contributor

I'm not sure you answered my question... Is it possible with this PR to set debug mode to True except for the dev-tools UI?

@byronz
Copy link
Contributor Author

byronz commented Apr 2, 2019

@nicolaskruchten there is no such dev_tools_ui=False in python code, it just adds a config field (redux state will parse the same config) which binds directly the value of debug.

HammadTheOne pushed a commit to HammadTheOne/dash that referenced this pull request May 28, 2021
@alexcjohnson
Merge pull request plotly#676 from plotly/slider-tooltip-desc
41f155c 
descriptions for (range)slider tooltip props
HammadTheOne pushed a commit that referenced this pull request Jul 23, 2021
@alexcjohnson
Merge pull request #676 from plotly/slider-tooltip-desc
c3797bd 
descriptions for (range)slider tooltip props
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T4rk1n T4rk1n T4rk1n left review comments

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add enable dev tools config
4 participants
@byronz @nicolaskruchten @alexcjohnson @T4rk1n