Add ignore option to component generation. #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,8 +42,7 @@ function writeError(msg, filePath) { | |||
| } | |||
|
|
|||
| function checkWarn(name, value) { | |||
| const excluded = ['setProps', 'id', 'className', 'style', 'dashEvents', 'fireEvent']; | |||
| if (value.length < 1 && !excluded.includes(name)) { | |||
| if (value.length < 1 && !excludedDocProps.includes(name.split('.').pop())) { | |||
There was a problem hiding this comment.
Small change in logic here with the name becoming name.split, can you explain what scenario this fixes?
There was a problem hiding this comment.
The name is actually the Component name + prop name and we only want the prop name.
| @@ -22,14 +22,17 @@ class _CombinedFormatter(argparse.ArgumentDefaultsHelpFormatter, | |||
|
|
|||
| # pylint: disable=too-many-locals | |||
| def generate_components(components_source, project_shortname, | |||
| package_info_filename='package.json'): | |||
| package_info_filename='package.json', | |||
| ignore='^_'): | |||
There was a problem hiding this comment.
This covers the __tests__ case mentioned in #486 but maybe a small set of defaults (e.g [__tests__, tests]) to cover both the dash-bootstrap-components and our own dash-component-boilerplate case would make sense. Surely there is never a case where this is desirable.
There was a problem hiding this comment.
This is an additional feature and should be documented in the changelog and the version be bumped.
T4rk1n
force-pushed
the
improve-generation-cli
branch
from
37ba9b2 to
fd096a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an ignore option to
dash-generate-componentscli, default is^_so it will ignore the__tests__folder pattern by default.Closes #486