Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bare exceptions #487

Merged
merged 7 commits into from
Dec 14, 2018
Merged

Bare exceptions #487

merged 7 commits into from
Dec 14, 2018

Conversation

shammamah-zz
Copy link
Contributor

@shammamah-zz shammamah-zz commented Dec 10, 2018

Addresses #304.

Pre-Merge checklist

  • All tests on CircleCI have passed.
  • All visual regression differences have been approved.
  • If changes are significant, a release candidate has been created and posted to Slack, the Plotly forums, and at the very top of the pull request.
  • You have updated the dash/version.py file and the top of CHANGELOG.md. For larger additions, your CHANGELOG.md entry includes sample code about how the feature works. The entry should also link to the original pull request(s).
  • Two people have 💃'd the pull request. You can be one of these people if you are a Dash core contributor.

Post-Merge checklist

  • You have tagged the release using git tag v<version_number> (for the contributor merging the PR).
  • You have pushed this tag using git push <tag_name> (for the contributor merging the PR).
  • You have deleted the branch.

Pre-Release checklist

  • Everything in the Pre-Merge checklist is completed. (Except the last two if this is a release candidate).
  • git remote show origin shows you are in the correct repository.
  • git branch shows that you are on the expected branch.
  • git status shows that there are no unexpected changes.
  • dash/version.py is at the correct version.

Release Step

  • python setup.py sdist to build.
  • twine upload dist/<the_version_you_just_built> to upload to PyPi.

Post-Release checklist

  • You have closed all issues that this pull request solves, and commented the new version number users should install.
  • If significant enough, you have created an issue about documenting the new feature or change and you have added it to the [Documentation] project.
  • You have created a pull request in [Dash Docs] with the new release of your feature by editing that project's requirements.txt file and you have assigned @chriddyp to review.

@shammamah-zz shammamah-zz requested a review from T4rk1n December 10, 2018 21:06
CHANGELOG.md Outdated Show resolved Hide resolved
dash/version.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@rmarren1
Copy link
Contributor

I'll take a look in a few hours, sorry for the delay!

@rmarren1
Copy link
Contributor

Looks great 💃

@shammamah-zz shammamah-zz merged commit 50c6c41 into master Dec 14, 2018
@shammamah-zz shammamah-zz deleted the bare-exceptions branch December 14, 2018 15:24
HammadTheOne pushed a commit to HammadTheOne/dash that referenced this pull request May 28, 2021
HammadTheOne pushed a commit that referenced this pull request Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants