[WIP] Revised version of R 'transpiler' with support for generator methods #483

rpkyle · 2018-12-06T22:42:30Z

OK, I've taken a stab at using the new generator method approach to component generation for R. If you two don't mind having another look, would be much appreciated. Closes #445.

@rmarren1 @T4rk1n

(N.B. This PR is the up-to-date version of this closed PR)

T4rk1n

Move big templates string as global at top of the file to make methods logic more readable.
Improve the docstrings.
Add --r-prefix option.
Call os.makedirs only once in component_generator.
Imports at top of files.
Copy the whole js/css dist.
generate_rpkg should use .get for field access, can't be sure that a package.json will contain some the fields used.

dash/development/_r_components_generation.py

dash/development/component_generator.py

dash/development/_r_components_generation.py

T4rk1n

Looking good, just need to fix json_to_r_type and I think we're good to go.

rmarren1

Few comments, looks good overall!

dash/development/_r_components_generation.py

rpkyle · 2018-12-14T17:00:25Z

Thanks for the additional reviews, I think the code has improved a lot -- both due to the useful factoring of the component generation in dash, but also because of the suggestions here and in the earlier PR.

@T4rk1n and I had a nice chat about json_to_r_type, before we 💃, I think I need to make some changes to this method, to handle two cases I missed previously:

if ['type']['name'] is custom, and the value is raw, the parameter type in R should be numeric() (or, more specifically, could be integer() or numeric())
if ['type']['name'] is enum, a bit more complicated to address: need to check option type in the value field, i.e. if option is 'click' the option type should be character(), but it could also be numeric(), or even an object in JSON

As for the other options:

if ['type']['name'] is func, node, or object, we're passing NULL for the time being

rpkyle · 2018-12-17T21:02:54Z

@T4rk1n Following up on our conversation from Friday, how does this version of props_to_r_type look?

dash/development/component_generator.py

rpkyle · 2018-12-18T18:32:14Z

@T4rk1n Following up on our conversation from Friday, how does this version of props_to_r_type look?

Following productive discussion with @T4rk1n, PR appears ready to merge. Will now do so as all requested changes to code have been made.

Modified Graph.react.js to include restyle event

Ryan Patrick Kyle added 4 commits December 5, 2018 00:19

refactored code to work with generator method

03b069d

fixed bug in component generation

9b10f91

Merge branch 'master' of github.com:plotly/dash into R2

c96092e

fixed bug in R help file function descriptions

670a03f

rpkyle changed the title R2 [WIP] Revised version of R 'transpiler' with support for generator methods Dec 6, 2018

This was referenced Dec 6, 2018

WIP Initial version of updated code for R transpiler #449

Closed

R code generation #445

Closed

Ryan Patrick Kyle added 2 commits December 7, 2018 23:29

edits to resolve pylint and flake8 unhappiness

27aeea7

flake8 passes locally

3aca86f

T4rk1n requested changes Dec 10, 2018

View reviewed changes

Ryan Patrick Kyle added 20 commits December 11, 2018 11:46

addresses format template issue

049bc4b

refactored code to avoid direct use of protocols

2c3212e

removed unnecessary brackets around string in object_type

6f615c1

added --r-prefix argument to cli

bd6bf8d

moved import importlib to preamble of .py

413c3da

clarified --rlang help for cli

a207992

edited _r_components_generation.py

ec5733a

refactored prefix assignment, added warning msg

ab39376

refactored prefix assignment, removed :s in templates

628ec82

updated docstrings

6afe218

rm unnecessary parens

d321153

eliminate unnecessary rewrites; fix prop_keys assignment

759941e

relocated check for R dir to component_generator.py

600ef85

added line to pull in CSS deps to inst/lib

d133043

added check for R dir to component_generator.py

a3804eb

renamed/refactored make_package_name_r to snake_case_to_camel_case

3f2eb22

rm more parens, replace apostrophes with dblquotes

6f954e5

remove spaces

bb352e8

refactor direct access to JSON keys to use .get instead

ffe7f5f

fixed 2 pylint issues

3cf3b22

T4rk1n reviewed Dec 13, 2018

View reviewed changes

dash/development/_r_components_generation.py Show resolved Hide resolved

T4rk1n reviewed Dec 13, 2018

View reviewed changes

dash/development/_r_components_generation.py Outdated Show resolved Hide resolved

T4rk1n approved these changes Dec 13, 2018

View reviewed changes

addresses T4rk1n comment about taking name attribute

14d23c2

rmarren1 approved these changes Dec 13, 2018

View reviewed changes

dash/development/_r_components_generation.py Show resolved Hide resolved

dash/development/_r_components_generation.py Outdated Show resolved Hide resolved

fixed missing quotation in propNames removed after earlier edits

8332e0c

Ryan Patrick Kyle added 3 commits December 17, 2018 15:52

fixed props, renamed/improved props_to_r method

47e8516

removed comment

dc8b254

jk, method *now* json_to_r_type >> props_to_r_type

059400f

nicolaskruchten reviewed Dec 17, 2018

View reviewed changes

dash/development/component_generator.py Outdated Show resolved Hide resolved

dash/development/component_generator.py Outdated Show resolved Hide resolved

dash/development/component_generator.py Outdated Show resolved Hide resolved

Ryan Patrick Kyle added 5 commits December 17, 2018 16:18

make warning msg for component prefix more explicit

0fc3d2d

edited to remove use of __contains__

3176684

remove unnecessary call to os.makedirs

f8041a7

inserted more detailed docstring for help file generator

df97a38

fix up docstrings for generate_js_metadata

adcddac

nicolaskruchten reviewed Dec 17, 2018

View reviewed changes

dash/development/component_generator.py Show resolved Hide resolved

Ryan Patrick Kyle added 4 commits December 18, 2018 11:21

removed dead function block

4ca4d58

converted else back to elif

f7d02dc

updated props_to_r_type

cdf8f9c

building R pkg now requires setting --r-prefix

4a67a6c

Ryan Patrick Kyle and others added 4 commits December 18, 2018 13:40

🐾 relocated importlib statements

99b6438

Merge branch 'master' into R2

5923e6b

removed unnecessary importlib import

28725e6

removed trailing whitespace

a073828

rpkyle merged commit 7654c22 into master Dec 18, 2018

rpkyle deleted the R2 branch December 18, 2018 19:43

AnnMarieW pushed a commit to AnnMarieW/dash that referenced this pull request Jan 6, 2022

Merge pull request plotly#483 from mako-npm/Add_restyle_prop

c5a63be

Modified Graph.react.js to include restyle event

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Revised version of R 'transpiler' with support for generator methods #483

[WIP] Revised version of R 'transpiler' with support for generator methods #483

rpkyle commented Dec 6, 2018 •

edited

Loading

T4rk1n left a comment •

edited by rpkyle

Loading

T4rk1n left a comment

rmarren1 left a comment

rpkyle commented Dec 14, 2018 •

edited

Loading

rpkyle commented Dec 17, 2018

rpkyle commented Dec 18, 2018

[WIP] Revised version of R 'transpiler' with support for generator methods #483

[WIP] Revised version of R 'transpiler' with support for generator methods #483

Conversation

rpkyle commented Dec 6, 2018 • edited Loading

T4rk1n left a comment • edited by rpkyle Loading

Choose a reason for hiding this comment

T4rk1n left a comment

Choose a reason for hiding this comment

rmarren1 left a comment

Choose a reason for hiding this comment

rpkyle commented Dec 14, 2018 • edited Loading

rpkyle commented Dec 17, 2018

rpkyle commented Dec 18, 2018

rpkyle commented Dec 6, 2018 •

edited

Loading

T4rk1n left a comment •

edited by rpkyle

Loading

rpkyle commented Dec 14, 2018 •

edited

Loading