Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow npm run lint to work through and display all errors #3092

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

BSd3v
Copy link
Contributor

@BSd3v BSd3v commented Nov 22, 2024

allowing npm run lint to go through all linting steps providing all the errors that need to be fixed, not just the first encountered failing test

… the errors that need to be fixed, not just the first encountered failing test
Copy link
Member

@ndrezn ndrezn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chatted with Brian about this change offline -- this looks good to me. If there is a linting error it will still show as failed in CI.

💃

@T4rk1n will give you final call

Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@T4rk1n T4rk1n merged commit 6856087 into plotly:dev Nov 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants