Add outputs_list to window.dash_clientside.callback_context #2881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnMarieW
reviewed
Jun 12, 2024
Comment on lines
272
to
276
| dc.callback_context.outputs_list = | ||
| Object.prototype.toString.call(outputs) === '[object Object]' | ||
| ? [outputs] | ||
| : outputs; | ||
| dc.callback_context.outputs = output; |
There was a problem hiding this comment.
It would be best to make the client side callback_context be the same as what's available on the server side. To achieve this, I think all that's necessary is to add the following here:
dc.callback_context.outputs_list = outputs;
There was a problem hiding this comment.
Ah, indeed! I made a mistake. I will make the necessary changes. Thank you!
insistence
changed the title
T4rk1n
reviewed
Jun 13, 2024
| @@ -4,6 +4,10 @@ This project adheres to [Semantic Versioning](https://semver.org/). | |||
|
|
|||
| ## [2.17.1] - 2024-06-12 | |||
|
|
|||
| ## Added | |||
There was a problem hiding this comment.
Need to go in a new section above the ## [2.17.1] with a ## [UNRELEASED] title.
There was a problem hiding this comment.
Thank you for your correction. I have made the necessary changes as per your suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start with a description of this PR. Then edit the list below to the items that make sense for your PR scope, and check off the boxes as you go!
Contributor Checklist
optionals
CHANGELOG.mdCloses #2877