-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update _pages.py - fix sorting for > 10 pages #2565
Conversation
@alexcjohnson @AnnMarieW
I hope these cover the changes well. |
@gothicVI Thanks for posting about this issue on the forum and creating this pull request. It looks great! @alexcjohnson regarding the question about id in the page_registry: The Typically when assigning an However, for tests, I think it would have been simpler - and better to just use the |
Thanks for the explanation of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 Thanks very much @gothicVI!
Fix #2564
Contributor Checklist
optionals
CHANGELOG.md