Fix args_grouping to handle "id" in the id
#2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcjohnson
reviewed
Jun 9, 2022
alexcjohnson
approved these changes
Jun 13, 2022
There was a problem hiding this comment.
Love it! 💃
FYI re: args_grouping_values - normally not a good idea to remove a feature outside of a major version, but (a) it was never documented, (b) this was partially broken, (c) it was only added in 2.4 so hasn't been available for long, and (d) Google is unaware of any mentions of it outside of the source code in which it was defined. So I think this is OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2086 where using id as a key within a component's id breaks the new callback context's args_grouping function.
Contributor Checklist
CHANGELOG.md