Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dropdown with a value but no options. #2065

Merged
merged 2 commits into from
May 24, 2022
Merged

Fix Dropdown with a value but no options. #2065

merged 2 commits into from
May 24, 2022

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented May 24, 2022

Fix Dropdown rendering error when a value is provided but no options. dcc.Dropdown(value="option"). Fix #2064

Contributor Checklist

  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

@T4rk1n T4rk1n requested a review from alexcjohnson as a code owner May 24, 2022 15:45
alexcjohnson
alexcjohnson approved these changes May 24, 2022
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Nice detective work! Changelog entry -> 🚢

@T4rk1n T4rk1n merged commit 34fd848 into dev May 24, 2022
@T4rk1n T4rk1n deleted the fix-dropdown-2064 branch May 24, 2022 16:18
@dhfbrown
Copy link

dhfbrown commented Apr 18, 2023 •
edited
Loading

Thank you for this fix.... I was at this for hours!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Cannot read properties of undefined (reading 'map')
3 participants
@T4rk1n @dhfbrown @alexcjohnson