Fix markdown mathjax in html #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nickmelnikov82 this looks great! Can you include the other two failing cases from #2003 in the tests, and add a changelog entry? The test failure looks spurious so with any luck it'll simply pass on the next try. |
nickmelnikov82
force-pushed
the
fix-markdown-mathjax-in-html
branch
from
4c5c15a to
c58a28d
Compare
nickmelnikov82
force-pushed
the
fix-markdown-mathjax-in-html
branch
from
c58a28d to
93a392a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in issue #2003,
dangerously_allow_html=True+mathjax=Trueworks in some cases, and in some cases not.The problem is that the markdown-parse recognizes whole string as the html object and stops further parsing. This PR fixes the processing of the mathjax in html.
Contributor Checklist
optionals
CHANGELOG.md