fix #919 - protect against pytest item with no funcargs #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tophers42 @finnhacks42 @wahchi would one of you be able to test with this patch and see whether it solves the issue with |
|
Thanks @alexcjohnson I applied your patch locally and it fixes my issue with pytest-black. Change LGTM. |
Marc-Andre-Rivet
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #919 the error seems to be that some
itemarguments, when you're runningpytestwith other plugins, don't have afuncargsattribute. I don't see any documentation of this attribute, but it seems harmless to just skip anyitemwithout it - this is only a post-failure extra diagnostic anyway.CHANGELOG.md