Sort also the directory name for proper ordering between css and js plugin folders #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikalexis
requested review from
alexcjohnson and
Marc-Andre-Rivet
as code owners
|
Seems reasonable to me, thanks! Just needs a CHANGELOG entry and it's ready to go. |
alexcjohnson
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a small fix.
I have sorted the os.walk function to achieve ordering in directories naming.
Many times you need to include plugins in the assets folders (e.g. 10_jquery/..., 20_bootstrap/...), but some plugins depends on others, so you need a way to load then first.
Until now, sorting is only available for filenames in each folder, which cannot cover the above case.
The workaround would be to have all files in one folder, but this will disable the ability to structure properly your assets folder.