-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix #1098 : also persist 0, empty string etc #1142
Conversation
Thanks @eddy-geek! The fix looks good, the only additional pieces we need are:
|
💔 Note on testing dash
the testing section does not have any commands. I tried this
but it fails with
next! chromedriver missing, I had to And finally it worked (with some usual chromedriver instability) Is that the proper way or did I miss something? Shouldn't this be in the contributing guide? |
4e671aa
to
fc4dad2
Compare
@alexcjohnson ready for review. I have checked that the changed test now fails as expected without the fix, with:
|
fixes plotly#1098 Persistence does not work for Input components when 0 is entered
5d7d209
to
d0296de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thanks! 💃
Good point about the test setup and commands - we're intending to simply remove dash-renderer-test-components
(building the relevant functionality into the tests directly) but we should add a note about chromedriver
. And for running the tests locally, it should suffice to just run pytest
plain.
fixes #1098 Persistence does not work for Input components when 0 is entered
Contributor Checklist
optionals
CHANGELOG.md