Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade deps for 2.7.0-RC1 release #8786

Merged
merged 12 commits into from
Nov 13, 2018
Merged

upgrade deps for 2.7.0-RC1 release #8786

merged 12 commits into from
Nov 13, 2018

Conversation

octonato
Copy link
Contributor

@octonato octonato commented Nov 9, 2018

No description provided.

@octonato octonato requested a review from ignasi35 November 9, 2018 13:40
ignasi35
ignasi35 approved these changes Nov 9, 2018
View reviewed changes
Copy link
Member

@ignasi35 ignasi35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merge at will (when build is green)

dwijnand
dwijnand suggested changes Nov 9, 2018
View reviewed changes
framework/project/Dependencies.scala Outdated Show resolved Hide resolved
@dwijnand
Copy link
Member

dwijnand commented Nov 9, 2018

Wonderful. Thank you Renato.

If you could create a ticket to remember to deal with those "See also" comments about scalaVersion, and put it on our board, that would be great. Thanks.

@mkurz mkurz mentioned this pull request Nov 9, 2018
Closed
marcospereira
marcospereira suggested changes Nov 12, 2018
View reviewed changes
Copy link
Member

@marcospereira marcospereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

documentation/manual/releases/release27/Highlights27.md Outdated Show resolved Hide resolved
framework/project/Dependencies.scala Show resolved Hide resolved
@dwijnand dwijnand merged commit 75d8436 into playframework:master Nov 13, 2018
@octonato octonato deleted the 2.7.0-RC1 branch November 13, 2018 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcospereira marcospereira marcospereira requested changes

@ignasi35 ignasi35 ignasi35 approved these changes

@dwijnand dwijnand dwijnand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@octonato @dwijnand @marcospereira @ignasi35