Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SBT dependency from reloader #7109

Merged
merged 1 commit into from
Mar 24, 2017
Merged

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Mar 20, 2017

This is the first step towards supporting Maven + Play along with #7093

@benmccann benmccann force-pushed the rm-sbt branch 8 times, most recently from 8543ce2 to da1e626 Compare March 24, 2017 04:32
@benmccann benmccann closed this Mar 24, 2017
@benmccann benmccann reopened this Mar 24, 2017
@benmccann benmccann closed this Mar 24, 2017
@benmccann benmccann reopened this Mar 24, 2017
@benmccann benmccann closed this Mar 24, 2017
@benmccann benmccann reopened this Mar 24, 2017
@mkurz
Copy link
Member

mkurz commented Mar 24, 2017

Ben you don't need to close/re-open pull requests to trigger a build.
You can just click "Restart build" directly in travis itself - even better you can also just use "Restart job" to restart failed jobs instead of the whole build (saves time).

@benmccann
Copy link
Contributor Author

Ah thanks!! Super happy to learn that!

@mkurz
Copy link
Member

mkurz commented Mar 24, 2017

Also check the "More options" dropdown on the right side - there you can e.g. clean the cache of your build. Sometimes this can be useful as well.

Copy link
Member

@gmethvin gmethvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmethvin gmethvin merged commit f49d96b into playframework:master Mar 24, 2017
@gmethvin gmethvin added this to the 2.6.0 milestone Mar 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants