Remove unused runSbtTask #7093
Merged
Remove unused runSbtTask #7093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Scalariform failed. |
|
Thanks for letting me know @mkurz. It's passing now |
gmethvin
approved these changes
Mar 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to refactor more of the Reloader into reusable components if possible. There's a bit of code that's shared between here and Lagom and it'd be nice to have it be an easily callable library.
I couldn't find anything that was using this. Lagom doesn't support it, so it brings the two reloaders a little closer. It also simplifies the code by not needing to support unused functionality. Let me know if there's some external project that depends on it somehow. I did some searches and couldn't find any.