Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for setting stacks when creating session #138

Merged
merged 3 commits into from
May 11, 2017
Merged

Add support for setting stacks when creating session #138

merged 3 commits into from
May 11, 2017

Conversation

marcosnils
Copy link
Contributor

xetorthio
xetorthio requested changes May 11, 2017
View reviewed changes
Copy link
Contributor

@xetorthio xetorthio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

handlers/exec.go Outdated
}

type execResponse struct {
StatusCode int `json:"status_code"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be exit_code

handlers/exec.go Outdated
)

type execRequest struct {
Command []string `json:"command"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should call this cmd like how Docker calls it

@marcosnils marcosnils merged commit 62c5d37 into master May 11, 2017
@marcosnils marcosnils deleted the button branch May 11, 2017 13:34
@yosifkit yosifkit mentioned this pull request May 19, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xetorthio xetorthio xetorthio requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcosnils @xetorthio