Skip to content

Clang 16 (c++20) build in CI fails #577

New issue
New issue
Closed
#600
Closed
Clang 16 (c++20) build in CI fails#577
#600
Labels
bugSomething isn't working
@elshize

Description

@elshize
elshize
opened on Feb 12, 2024

Clang 16 (c++20) build in CI fails:

https://github.com/pisa-engine/pisa/actions/runs/7865449374/job/21458386783

65.16 -- Compiling and running to test HAVE_POSIX_REGEX
65.20 -- Performing Test HAVE_POSIX_REGEX -- failed to compile

Activity

elshize
added
bugSomething isn't working
on Feb 12, 2024
lgrz

lgrz commented on Feb 1, 2025

@lgrz
lgrz
on Feb 1, 2025
Collaborator

Looks like this problem may be building OK and now it is a timeout issue?
Noting this for future reference. The build logs below are from 55b3c3c.

...
2025-01-07T14:45:23.2139306Z 23: [2025-01-07 14:45:23.210] [info] number of elements / number of blocks: 21.398842
2025-01-07T14:45:23.2454649Z 23: [2025-01-07 14:45:23.244] [info] Processing 10000 documents
2025-01-07T14:45:29.3016542Z 123/123 Test  #23: test_compress:Compress quantized index ..................................................................***Timeout 1500.07 sec
2025-01-07T14:45:29.3070292Z 
2025-01-07T14:45:29.3072197Z Errors while running CTest
2025-01-07T14:45:29.3072753Z 99% tests passed, 1 tests failed out of 123
2025-01-07T14:45:29.3073228Z 
2025-01-07T14:45:29.3073439Z Total Test time (real) = 1571.92 sec
2025-01-07T14:45:29.3073860Z 
2025-01-07T14:45:29.3074058Z The following tests FAILED:
2025-01-07T14:45:29.3074734Z 	 23 - test_compress:Compress quantized index (Timeout)
2025-01-07T14:45:29.4548267Z ##[error]Process completed with exit code 8.

Ref: https://github.com/pisa-engine/pisa/actions/runs/12653075572/job/35257363391#step:4:40145

elshize

elshize commented on Feb 2, 2025

@elshize
elshize
on Feb 2, 2025
MemberAuthor

Yes, I believe the problem is the build with sanitizers on. Because of the sanitizers, it executes slowly. I've been thinking of using a smaller collection for these tests, but haven't had the time to look into it yet.

lgrz

lgrz commented on Feb 2, 2025

@lgrz
lgrz
on Feb 2, 2025
Collaborator

Ok thanks good to know we can probably use smaller collection fixtures and the timeout may be because ASAN, etc.

elshize
added a commit that references this issue on Feb 15, 2025

Use tiny collection for compression test

9d8586e
elshize
mentioned this on Feb 15, 2025
elshize
added a commit that references this issue on Feb 15, 2025

Use tiny collection for compression test

ee28e24
elshize

elshize commented on Feb 15, 2025

@elshize
elshize
on Feb 15, 2025
MemberAuthor

@lgrz I pushed a change that uses a very small collection for this particular test. Hopefully that helps. I tagged you as a reviewer.

lgrz

lgrz commented on Feb 16, 2025

@lgrz
lgrz
on Feb 16, 2025
Collaborator

Thanks @elshize will take a look

elshize
added a commit that references this issue on Feb 18, 2025

Use tiny collection for compression test

c082a5a
elshize
closed this as completedin #600on Feb 18, 2025
elshize
closed this as completedin f0c2d7con Feb 18, 2025
elshize

elshize commented on Feb 18, 2025

@elshize
elshize
on Feb 18, 2025
MemberAuthor

Fixed 🎉

lgrz
added a commit that references this issue on Feb 18, 2025

Use tiny collection for compression test

f0c2d7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      Clang 16 (c++20) build in CI fails · Issue #577 · pisa-engine/pisa