Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for llvm libunwind #3683

Merged
merged 18 commits into from
Jan 4, 2022

Conversation

SchrodingerZhu
Copy link
Contributor

Signed-off-by: SchrodingerZhu i@zhuyi.fan

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 17, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 17, 2021
@SchrodingerZhu
Copy link
Contributor Author

image

@SchrodingerZhu
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Dec 18, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/449/cobertura/
(Coverage detail url is limited office network access)

lines: 42.5% (47528 out of 111814)
branches: 6.0% (73019 out of 1208753)

@SchrodingerZhu
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Dec 18, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/450/cobertura/
(Coverage detail url is limited office network access)

lines: 42.5% (47525 out of 111814)
branches: 6.0% (73004 out of 1208753)

@SchrodingerZhu
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Dec 24, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/604/cobertura/
(Coverage detail url is limited office network access)

lines: 42.6% (47931 out of 112515)
branches: 6.1% (73497 out of 1210532)

@SchrodingerZhu
Copy link
Contributor Author

@JaySon-Huang please have a try~

@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Dec 28, 2021

Found another issue(#3760) that is not related to this change. After fixing that locally, this commit(c6580ae) can be built successfully.


Will check the code changes later.

@SchrodingerZhu
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Dec 28, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/703/cobertura/
(Coverage detail url is limited office network access)

lines: 42.7% (48195 out of 112780)
branches: 6.1% (74577 out of 1213233)

@SchrodingerZhu
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Dec 30, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/781/cobertura/
(Coverage detail url is limited office network access)

lines: 43.1% (48910 out of 113396)
branches: 6.1% (76153 out of 1247810)

@JaySon-Huang
Copy link
Contributor

/hold
Wait before the release-5.4 branch is created

Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
Signed-off-by: Schrodinger ZHU Yifan <i@zhuyi.fan>
Signed-off-by: Schrodinger ZHU Yifan <i@zhuyi.fan>
Signed-off-by: Schrodinger ZHU Yifan <i@zhuyi.fan>
Signed-off-by: Schrodinger ZHU Yifan <i@zhuyi.fan>
Signed-off-by: Schrodinger ZHU Yifan <i@zhuyi.fan>
@SchrodingerZhu
Copy link
Contributor Author

/unhold

https://github.com/pingcap/tics/tree/release-5.4 is created

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 4, 2022
@JaySon-Huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4a45175

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 4, 2022
@ti-chi-bot
Copy link
Member

@SchrodingerZhu: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Jan 4, 2022

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/816/cobertura/
(Coverage detail url is limited office network access)

lines: 43.6% (49723 out of 114001)
branches: 6.4% (80884 out of 1261222)

@ti-chi-bot ti-chi-bot merged commit 1a05883 into pingcap:master Jan 4, 2022
@JaySon-Huang JaySon-Huang deleted the adjust-for-llvm-unwind branch January 4, 2022 04:01
SchrodingerZhu and others added 3 commits January 4, 2022 16:53
Signed-off-by: Schrodinger ZHU Yifan <i@zhuyi.fan>
Signed-off-by: Schrodinger ZHU Yifan <i@zhuyi.fan>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants