Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dm: support ignore online-ddl in precheck #9986

Merged
merged 3 commits into from
Jul 12, 2022
Merged

dm: support ignore online-ddl in precheck #9986

merged 3 commits into from
Jul 12, 2022

Conversation

Ehco1996
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

as title

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 23, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn June 23, 2022 09:27
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 23, 2022
@Ehco1996
Copy link
Contributor Author

could you please take another look for this pr ? thanks 🧡🧡🧡
@sunzhaoyang

@TomShawn TomShawn requested review from ran-huang and sunzhaoyang and removed request for TomShawn June 24, 2022 03:00
@TomShawn TomShawn added area/dm translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed missing-translation-status This PR does not have translation status info. labels Jun 24, 2022
sunzhaoyang
sunzhaoyang approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@sunzhaoyang sunzhaoyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ehco1996
Copy link
Contributor Author

@TomShawn ptal

@Ehco1996
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@Ehco1996: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Ehco1996
Copy link
Contributor Author

ping @ran-huang ptal

ran-huang
ran-huang reviewed Jul 12, 2022
View reviewed changes
dm/dm-precheck.md Outdated
@@ -124,6 +124,7 @@ tiup dmctl check-task ./task.yaml
|table_schema|检查上游 MySQL 表结构的兼容性|
|schema_of_shard_tables|检查上游 MySQL 多实例分库分表的表结构一致性|
|auto_increment_ID|关闭检查上游 MySQL 多实例分库分表的自增主键冲突|
|online_ddl|关闭检查上游是否处于 [Online-DDL](/dm/feature-online-ddl.md) 过程中|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“关闭”应该删掉吧。这个表里有的 row 没写“关闭”，有的写了“关闭”，但我理解它们都是一个意思。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Ehco1996
Ehco1996 commented Jul 12, 2022
View reviewed changes
dm/dm-precheck.md Outdated Show resolved Hide resolved
ran-huang
ran-huang reviewed Jul 12, 2022
View reviewed changes
dm/dm-precheck.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 12, 2022
@ran-huang
Copy link
Contributor

/verify

1 similar comment
@ran-huang
Copy link
Contributor

/verify

@ran-huang ran-huang added the require-LGT1 Indicates that the PR requires an LGTM. label Jul 12, 2022
@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 364bfe8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 12, 2022
@ran-huang
Copy link
Contributor

/verify

1 similar comment
@ran-huang
Copy link
Contributor

/verify

@ti-chi-bot ti-chi-bot merged commit 8424fa1 into pingcap:master Jul 12, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 12, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10469.

ti-chi-bot added a commit that referenced this pull request Jul 12, 2022
@ti-chi-bot
dm: support ignore online-ddl in precheck (#9986) (#10469)
6553ad3
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jan 18, 2023
@ran-huang ran-huang mentioned this pull request Jan 18, 2023
Merged
14 tasks
This was referenced Mar 7, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang approved these changes

@sunzhaoyang sunzhaoyang sunzhaoyang approved these changes

Assignees

@ran-huang ran-huang

Labels
area/dm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ehco1996 @ti-chi-bot @ran-huang @sunzhaoyang @TomShawn