Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Aurora MySQL dumpling command #6847

Merged
merged 20 commits into from
Aug 30, 2021
Merged

Conversation

fengou1
Copy link
Contributor

@fengou1 fengou1 commented Aug 12, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 12, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn August 12, 2021 03:29
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 12, 2021
@fengou1
Copy link
Contributor Author

fengou1 commented Aug 12, 2021

/review @lichunzhu

@@ -79,12 +79,12 @@ summary: 了解如何使用 TiDB Lightning 从 Amazon Aurora MySQL 迁移全量
1. 使用 Dumpling 导出表结构文件:

```
./dumpling --host 127.0.0.1 --port 4000 --user root --password password --no-data --output ./schema --filter "mydb.*"
./dumpling --host database-1.cedtft9htlae.us-west-2.rds.amazonaws.com --port 3306 --user root --password password --consistency none --no-data --output ./schema --filter "mydb.*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think locking these tables for a short while is better.

Suggested change
./dumpling --host database-1.cedtft9htlae.us-west-2.rds.amazonaws.com --port 3306 --user root --password password --consistency none --no-data --output ./schema --filter "mydb.*"
./dumpling --host database-1.cedtft9htlae.us-west-2.rds.amazonaws.com --port 3306 --user root --password password --consistency lock --no-data --output ./schema --filter "mydb.*"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried the command with --consistency lock, it works. To keep doc identify with TiDB Cloud https://docs.pingcap.com/tidbcloud/public-preview/migrate-from-aurora-bulk-import, shall we keep none?

Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 12, 2021
@fengou1
Copy link
Contributor Author

fengou1 commented Aug 12, 2021

  1. Aurora MySQL does not support SUPR privileges allow to local table (consistent) so that we need --consistency none
  2. Aurora MySQL use port 3306

@lichunzhu
Copy link
Contributor

  1. Aurora MySQL does not support SUPR privileges allow to local table (consistent) so that we need --consistency none
  2. Aurora MySQL use port 3306

But we can lock tables in Aurora MySQL.

@fengou1
Copy link
Contributor Author

fengou1 commented Aug 12, 2021

  1. Aurora MySQL does not support SUPR privileges allow to local table (consistent) so that we need --consistency none
  2. Aurora MySQL use port 3306

But we can lock tables in Aurora MySQL.

Just check the privileges of Aurora MySQL, and you are right, we are able to lock the table.

@fengou1
Copy link
Contributor Author

fengou1 commented Aug 12, 2021

/review @IANTHEREAL

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 24, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ece090a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 24, 2021
@TomShawn
Copy link
Contributor

/rebase

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 30, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 904faa7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 30, 2021
@ti-chi-bot ti-chi-bot merged commit 93903cb into pingcap:master Aug 30, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7013.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7014.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7015.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Aug 30, 2021
@en-jin19 en-jin19 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants