-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Aurora MySQL dumpling command #6847
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/review @lichunzhu |
@@ -79,12 +79,12 @@ summary: 了解如何使用 TiDB Lightning 从 Amazon Aurora MySQL 迁移全量 | |||
1. 使用 Dumpling 导出表结构文件: | |||
|
|||
``` | |||
./dumpling --host 127.0.0.1 --port 4000 --user root --password password --no-data --output ./schema --filter "mydb.*" | |||
./dumpling --host database-1.cedtft9htlae.us-west-2.rds.amazonaws.com --port 3306 --user root --password password --consistency none --no-data --output ./schema --filter "mydb.*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think locking these tables for a short while is better.
./dumpling --host database-1.cedtft9htlae.us-west-2.rds.amazonaws.com --port 3306 --user root --password password --consistency none --no-data --output ./schema --filter "mydb.*" | |
./dumpling --host database-1.cedtft9htlae.us-west-2.rds.amazonaws.com --port 3306 --user root --password password --consistency lock --no-data --output ./schema --filter "mydb.*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried the command with --consistency lock, it works. To keep doc identify with TiDB Cloud https://docs.pingcap.com/tidbcloud/public-preview/migrate-from-aurora-bulk-import, shall we keep none?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
But we can lock tables in Aurora MySQL. |
Just check the privileges of Aurora MySQL, and you are right, we are able to lock the table. |
/review @IANTHEREAL |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: ece090a
|
/rebase |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 904faa7
|
In response to a cherrypick label: new pull request created: #7013. |
In response to a cherrypick label: new pull request created: #7014. |
In response to a cherrypick label: new pull request created: #7015. |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?