Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add link fail fast #9862

Merged
merged 14 commits into from
Aug 8, 2022
Merged

ci: add link fail fast #9862

merged 14 commits into from
Aug 8, 2022

Conversation

ran-huang
Copy link
Contributor

What is changed, added or deleted? (Required)

This action should fail when the PR introduces a broken link.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ran-huang
add link fail fast
b5966e4 
Signed-off-by: Ran <huangran.alex@gmail.com>
@ran-huang ran-huang added translation/doing This PR's assignee is translating this PR. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. labels Aug 6, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 6, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 6, 2022
@ti-chi-bot ti-chi-bot requested a review from shichun-0415 August 6, 2022 10:09
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 6, 2022
@ran-huang
accept 429; add test file
93f7a5c 
Signed-off-by: Ran <huangran.alex@gmail.com>
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 6, 2022
@ran-huang
include md in the root dir
77b73f1 
Signed-off-by: Ran <huangran.alex@gmail.com>
@ran-huang
add links to lycheeignore
50eb44c 
Signed-off-by: Ran <huangran.alex@gmail.com>
@ran-huang ran-huang removed the request for review from shichun-0415 August 6, 2022 10:20
@ran-huang
update test.md
cca6958 
Signed-off-by: Ran <huangran.alex@gmail.com>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 6, 2022
@ran-huang
remove verbose
9663f1d 
Signed-off-by: Ran <huangran.alex@gmail.com>
@ran-huang
try only check modified files
87848b4 
Signed-off-by: Ran <huangran.alex@gmail.com>
@ran-huang
add fetch depth
5c11403
@ran-huang
test docHome
995695e 
Signed-off-by: Ran <huangran.alex@gmail.com>
@ran-huang
test doc home
6dfea0a 
Signed-off-by: Ran <huangran.alex@gmail.com>
@ran-huang ran-huang marked this pull request as ready for review August 6, 2022 10:53
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 6, 2022
@ran-huang ran-huang requested review from qiancai and Oreoxmt August 6, 2022 10:53
ran-huang
ran-huang commented Aug 6, 2022
View reviewed changes
_docHome.md Outdated
@@ -13,7 +13,7 @@ TiDB Cloud is a fully-managed Database-as-a-Service (DBaaS) that brings everythi

<DocHomeCardContainer>

<DocHomeCard href="https://docs.pingcap.com/tidbcloud" icon="doc2" label="TiDB Cloud Docs">
<DocHomeCard href="https://docs.pingcap.com/tiud" icon="doc2" label="TiDB Cloud Docs">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a test link. Revert this before merging.

Oreoxmt
Oreoxmt approved these changes Aug 8, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

.github/workflows/link.yaml Outdated
args: -E --exclude-mail -v -i -n -t 45 -- **/*.md
# Accept 429 for now due to github rate limit.
# See https://github.com/lycheeverse/lychee/issues/634
args: -E --exclude-mail -i -n -t 45 -a 429 -- **/*.md *.md
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果接受 429，那可能就会错过一些真正 400 的 GitHub 网页，例如 #9455 (comment) 👀

.github/workflows/link-fail-fast.yaml Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 8, 2022
ran-huang
ran-huang commented Aug 8, 2022
View reviewed changes
.github/workflows/link.yaml Outdated Show resolved Hide resolved
@ran-huang @Oreoxmt
Update .github/workflows/link-fail-fast.yaml
76f1019 
Co-authored-by: Aolin <aolin.zhang@pingcap.com>
ran-huang
ran-huang commented Aug 8, 2022
View reviewed changes
_docHome.md Outdated Show resolved Hide resolved
@ran-huang ran-huang added the require-LGT1 Indicates that the PR requires an LGTM. label Aug 8, 2022
@ran-huang
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c615ad4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 8, 2022
@ti-chi-bot ti-chi-bot merged commit c2ab0d0 into master Aug 8, 2022
@ran-huang ran-huang deleted the link-check-in-pr branch August 8, 2022 07:26
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 8, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9874.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Aug 8, 2022
@ran-huang @ti-chi-bot
This is an automated cherry-pick of pingcap#9862
64e82de 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot added a commit that referenced this pull request Aug 8, 2022
@ti-chi-bot
ci: add link fail fast (#9862) (#9874)
c2496b9
@ran-huang ran-huang self-assigned this Aug 12, 2022
@ran-huang ran-huang mentioned this pull request Aug 13, 2022
Merged
12 tasks
This was referenced Aug 15, 2022
Merged
Merged
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Aug 18, 2022
@ran-huang ran-huang mentioned this pull request Aug 18, 2022
Merged
13 tasks
This was referenced Aug 18, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@qiancai qiancai Awaiting requested review from qiancai

Assignees

@ran-huang ran-huang

Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. require-LGT1 Indicates that the PR requires an LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ran-huang @ti-chi-bot @Oreoxmt